[bisq-network/bisq-core] Add basic tests for Price and OfferUtil classes (#160)
chirhonul
notifications at github.com
Mon Aug 20 12:29:07 UTC 2018
Also improve some existing comments, add new docstrings and some further invariant checks to some methods.
You can view, comment on, or merge this pull request online at:
https://github.com/bisq-network/bisq-core/pull/160
-- Commit Summary --
* Remove unused Price.getPrecision() method
* Add some comments to Price
* Add basic tests for Price.parse() and .valueOf()
* Rename param inputValue to value in Price.parse()
* Improve comments in OfferUtil
* Add more checkArgument verification to OfferUtil.getAdjustedAmount()
* Add basic OfferUtilTest unit tests
-- File Changes --
M src/main/java/bisq/core/monetary/Price.java (36)
M src/main/java/bisq/core/offer/OfferUtil.java (42)
A src/test/java/bisq/core/monetary/PriceTest.java (133)
A src/test/java/bisq/core/offer/OfferUtilTest.java (95)
-- Patch Links --
https://github.com/bisq-network/bisq-core/pull/160.patch
https://github.com/bisq-network/bisq-core/pull/160.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq-core/pull/160
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20180820/d069a389/attachment.html>
More information about the bisq-github
mailing list