[bisq-network/bisq-common] Fix broadcast issues (#37)

[chirhonul]

chirhonul approved this pull request.

utACK 0ceb5f3.

The new commit for `libdohj` refers to:

* https://github.com/bisq-network/libdohj/commit/5047c8

The old commit was:

* https://github.com/bisq-network/libdohj/commit/23dd03f5

The only meaningful diff between those two commits in `libdohj` seems to be that `core/pom.xml` changed, in the following commit:

* https://github.com/bisq-network/libdohj/commit/a9b8346

That in turn moves the `network.bisq.bitcoinj` dependency for `libdohj` from commit `2033cc60` to `1fd8909a`.

The only meaningful commit within that range for `bitcoinj` in turn is:

* https://github.com/bisq-network/bitcoinj/commit/1fd8909af3

That in turn seems to empirically fix a bug in Bisq where transactions take a very long time to broadcast, which was present from v0.6.3 until current time. I and @ManfredKarrer debugged this issue and while we don't understand 100% why that code change resolves the issue, it does seem to workaround it, and I'm fine with the comments added in https://github.com/bisq-network/bitcoinj/commit/1fd8909af3 to document the issue for future root cause fixes.

I will note that the other changes to our libraries seems to have been merged without prior review, which might not be ideal.

The current PR seems like it is updating the version used in `libdohj` as intended, and `libdohj` in turn wraps our fork of `bitcoinj` (for reasons I don't quite understand yet).



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq-common/pull/37#pullrequestreview-148201744
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20180821/6dbec2d0/attachment.html>