[bisq-network/bisq-core] Fix broadcast issues (#165)

[Manfred Karrer]

ManfredKarrer commented on this pull request.



> +                                "issues). So if we just go on in the application logic and treat it as successful and the " +
+                                "tx will be broadcasted successfully later all is fine.\n" +
+                                "If it will fail to get broadcasted, " +
+                                "it will lead to a failure state, the same as if we would trigger a failure due the timeout." +
+                                "So we can assume that this behaviour will lead to less problems as otherwise.\n" +
+                                "Long term we should implement better monitoring for Tor and the provided Bitcoin nodes to " +
+                                "find out why those delays happen and add some rollback behaviour to the app state in case " +
+                                "the tx will never get broadcasted.",
+                        exception.toString(),
+                        txId,
+                        exception.getDelay());
+
+                // The commit is required in case the tx is spent by a follow up tx as otherwise there would be an
+                // InsufficientMoneyException thrown. But in some test scenarios we also got issues with wallet
+                // inconsistency if the tx was committed twice. It should be prevented by the maybeCommitTx methods but
+                // not 100% if that is always the case. Just added that comment to make clear that this might be a risky

Ah maybe there was a misunderstanding. It was meant: The wallet.maybeCommitTx() call is required...

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq-core/pull/165#discussion_r211775461
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20180821/ce32d9e6/attachment.html>