[bisq-network/bisq-core] Fix broadcast issues (#165)

Manfred Karrer notifications at github.com
Tue Aug 21 22:11:12 UTC 2018


ManfredKarrer commented on this pull request.



> @@ -42,8 +42,41 @@
         void onSuccess(Transaction transaction);
 
         default void onTimeout(TxBroadcastTimeoutException exception) {
-            log.error("TxBroadcaster.onTimeout " + exception.toString());
-            onFailure(exception);
+            Transaction tx = exception.getLocalTx();
+            if (tx != null) {
+                String txId = tx.getHashAsString();
+                log.warn("TxBroadcaster.onTimeout called: {}\n" +
+                                "We optimistically assume that the tx broadcast succeeds later and call onSuccess on the " +
+                                "callback handler. This behaviour carries less potential problems than if we would trigger " +
+                                "a failure (e.g. which would cause a failed create offer attempt of failed take offer attempt).\n" +
+                                "We have no guarantee how long it will take to get the information that sufficiently BTC " +
+                                "nodes have reported back to BitcoinJ that the tx is in their mempool.\n" +
+                                "In normal situations " +
+                                "that's very fast but in some cases it can take minutes (mostly related to Tor connection " +
+                                "issues). So if we just go on in the application logic and treat it as successful and the " +
+                                "tx will be broadcasted successfully later all is fine.\n" +

Fixed in next PR.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq-core/pull/165#discussion_r211776284
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20180821/606bf26f/attachment.html>


More information about the bisq-github mailing list