[bisq-network/bisq-core] Fix broadcast issues (#165)

[Manfred Karrer]

ManfredKarrer commented on this pull request.



> +                                "callback handler. This behaviour carries less potential problems than if we would trigger " +
+                                "a failure (e.g. which would cause a failed create offer attempt of failed take offer attempt).\n" +
+                                "We have no guarantee how long it will take to get the information that sufficiently BTC " +
+                                "nodes have reported back to BitcoinJ that the tx is in their mempool.\n" +
+                                "In normal situations " +
+                                "that's very fast but in some cases it can take minutes (mostly related to Tor connection " +
+                                "issues). So if we just go on in the application logic and treat it as successful and the " +
+                                "tx will be broadcasted successfully later all is fine.\n" +
+                                "If it will fail to get broadcasted, " +
+                                "it will lead to a failure state, the same as if we would trigger a failure due the timeout." +
+                                "So we can assume that this behaviour will lead to less problems as otherwise.\n" +
+                                "Long term we should implement better monitoring for Tor and the provided Bitcoin nodes to " +
+                                "find out why those delays happen and add some rollback behaviour to the app state in case " +
+                                "the tx will never get broadcasted.",
+                        exception.toString(),
+                        txId,

Fixed in next PR.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq-core/pull/165#discussion_r211776328
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20180821/1815cdd4/attachment-0001.html>