[bisq-network/bisq-core] Refactor OpReturnParser to make it easier to test (#169)

[chirhonul]

We don't get all the way to pure functions or any new tests in this PR, unfortunately. See commits for more details.
You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq-core/pull/169

-- Commit Summary --

  * Return TxOutputType instead of passing around TempTxOutput in OpReturnParser
  * Propagate TxOutputType result up to TxOutputParser
  * Invert logic of second argument to OpReturnParser.validate()
  * Add basic docstring to OpReturnParser.validate()
  * Rename OpReturnParser method to parseAndValidate()

-- File Changes --

    M src/main/java/bisq/core/dao/node/parser/OpReturnCompReqParser.java (4)
    M src/main/java/bisq/core/dao/node/parser/OpReturnParser.java (101)
    M src/main/java/bisq/core/dao/node/parser/OpReturnProposalParser.java (2)
    M src/main/java/bisq/core/dao/node/parser/TxOutputParser.java (11)

-- Patch Links --

https://github.com/bisq-network/bisq-core/pull/169.patch
https://github.com/bisq-network/bisq-core/pull/169.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq-core/pull/169
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20180826/b13ada75/attachment-0001.html>