[bisq-network/bisq-common] Refactoring TxParser (#39)

[chirhonul]

chirhonul approved this pull request.

utACK 8fc7b630.

In commit 75c7b65 we describe various changes that are not actually made in this commit (or this repo). For future reference I'd suggest making the commits describe only the changes they actually contain, but with the pending merge back to a monorepo we will likely lose this commit history anyway, so it's a fairly academic point..

> @@ -1335,8 +1335,7 @@ message Tx {
     repeated BaseTxOutput tx_outputs = 1;
     TxType txType = 2;
     int64 burnt_fee = 3;
-    int32 lock_time = 4;
-    int32 unlock_block_height = 5;
+    int32 unlock_block_height = 4;

This `.proto` change is backwards compatible, but in conversation @ManfredKarrer confirmed that these messages are DAO-related and not yet live, so I believe this should be safe.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq-common/pull/39#pullrequestreview-149789020
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20180827/a333078a/attachment.html>