[bisq-network/bisq-core] TxParser refactoring to get rid of ParsingModel (#171)
chirhonul
notifications at github.com
Tue Aug 28 08:50:26 UTC 2018
chirhonul approved this pull request.
Lightly tested ACK 3ca17c4c.
Seeing ~2x as much code removed as code added always makes it likely that the changeset is a move in the right direction, but in this case the code also ends up with a lot more concerns being contained more in the classes that are concerned with parsing that structure, and with input-to-output behavior
that is easier to reason about, and will be easier to test.
Great work on this change!
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq-core/pull/171#pullrequestreview-150022608
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20180828/1d0227fd/attachment.html>
More information about the bisq-github
mailing list