[bisq-network/bisq-core] Simplify TxParser.getBisqTxType() and add some basic tests (#172)

[chirhonul]

You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq-core/pull/172

-- Commit Summary --

  * Remove stale TODO
  * Simplify return values for TxParser.is{FeeAnd}PhaseValid
  * Make TxParser.is{FeeAnd}PhaseValid not need TempTx
  * fixup: Actually validate fee and phase of proposals in TxParser
  * Remove TempTx argument from TxParser.getOptionalOpReturnType()
  * Make TxParser.getTxType() and getTxTypeForOpReturn()  static
  * Add docstring for TxParser.findGenesisTx()
  * Add more detailed logging to TxParser.getTxType()
  * Remove unused result variable assignment in PriceTest
  * Add basic TxParser.getTxType() tests
  * Rename method to TxParser.getBisqTxType()

-- File Changes --

    M src/main/java/bisq/core/dao/node/parser/TxParser.java (118)
    M src/test/java/bisq/core/dao/node/parser/TxParserTest.java (199)
    M src/test/java/bisq/core/monetary/PriceTest.java (4)

-- Patch Links --

https://github.com/bisq-network/bisq-core/pull/172.patch
https://github.com/bisq-network/bisq-core/pull/172.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq-core/pull/172
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20180828/2289145f/attachment.html>