[bisq-network/bisq] Issue 2021 - Asset validation override issues in many coin extensions (#2025)

[CaveSpectre11]

  - Fix length issue in regular expression of validate() override in main asset coins.
    PIVX most likely started the 1+{25,34} that was then proliferated through the copies.
    While it likely should be 1+33, I could only confirm that 35 is too long, so the
    code is changed to be 1+{24,33} in order to reduce it by the presumed forgotten first
    character.
  - Fixup testInvalidAddresses() to better test regex rules in test asset coins.  The PIVX
    base code was testing against 3 addresses, that all had a different first character,
    therefore none of the rest of the regular expression was being tested.  Changed those
    addresses (and others for other susceptable coins) to accurately test first character
    match, length, and invalid characters in the 24 to 33 series.
You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/2025

-- Commit Summary --

  * Issue 2021 - Asset validation override issues in many coin extensions

-- File Changes --

    M assets/src/main/java/bisq/asset/coins/BitCloud.java (2)
    M assets/src/main/java/bisq/asset/coins/Credits.java (2)
    M assets/src/main/java/bisq/asset/coins/Cryptonodes.java (2)
    M assets/src/main/java/bisq/asset/coins/DRIP.java (2)
    M assets/src/main/java/bisq/asset/coins/FuturoCoin.java (2)
    M assets/src/main/java/bisq/asset/coins/MegaCoin.java (2)
    M assets/src/main/java/bisq/asset/coins/MonetaryUnit.java (2)
    M assets/src/main/java/bisq/asset/coins/Neos.java (2)
    M assets/src/main/java/bisq/asset/coins/NewPowerCoin.java (2)
    M assets/src/main/java/bisq/asset/coins/PIVX.java (2)
    M assets/src/main/java/bisq/asset/coins/PZDC.java (2)
    M assets/src/main/java/bisq/asset/coins/QMCoin.java (2)
    M assets/src/main/java/bisq/asset/coins/SUB1X.java (2)
    M assets/src/main/java/bisq/asset/coins/Wavi.java (2)
    M assets/src/test/java/bisq/asset/coins/BitCloudTest.java (7)
    M assets/src/test/java/bisq/asset/coins/CreditsTest.java (2)
    M assets/src/test/java/bisq/asset/coins/CryptonodesTest.java (7)
    M assets/src/test/java/bisq/asset/coins/DRIPTest.java (7)
    M assets/src/test/java/bisq/asset/coins/FuturoCoinTest.java (1)
    M assets/src/test/java/bisq/asset/coins/MegaCoinTest.java (7)
    M assets/src/test/java/bisq/asset/coins/NeosTest.java (1)
    M assets/src/test/java/bisq/asset/coins/NewPowerCoinTest.java (7)
    M assets/src/test/java/bisq/asset/coins/PIVXTest.java (9)
    M assets/src/test/java/bisq/asset/coins/PZDCTest.java (3)
    M assets/src/test/java/bisq/asset/coins/QMCoinTest.java (9)
    M assets/src/test/java/bisq/asset/coins/SUB1XTest.java (1)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/2025.patch
https://github.com/bisq-network/bisq/pull/2025.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/2025
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20181201/c9fe8fcf/attachment.html>