[bisq-network/bisq-website] Rework download links (#102)
Steve Jain
notifications at github.com
Wed Dec 5 14:12:05 UTC 2018
I found issues with download links:
- primary download links did work in firefox at all (!)
- ios showed ios and macos text at the same time
- inconsistent os highlighting in download menus (windows and macos particularly)
- add fallback text for non-windows-mac-linux users
Other notable changes:
- re-add analytics (the ga initialization script was missing before)
- remove all 32-bit links and rename 64-bit links (the '64 Bit' text from 3d23ce25b0ff8e080987076ddf467c0436720764 is gone with this PR so that should be an easy merge conflict)
So I spent some time yesterday reworking the code and UI for download links. While seemingly minor I figured it worth the time because getting users to download the Bisq software is probably our #1 goal for the website, and it should be a flawless experience.
@ripcurlx if you or someone with access to Analytics can verify that analytics are working again, that would be great. I was getting ga errors before, and I'm not getting them any more, but I can't be 100% sure events are actually being recorded on the server.
You can view, comment on, or merge this pull request online at:
https://github.com/bisq-network/bisq-website/pull/102
-- Commit Summary --
* Revert 88fe6b67d10a937e5068a5493dfa016504b4c619
* Remove 32-bit links from download page & menu
* Rename '64 bit' links to '.exe' and '.deb'
* Add download links to os text
* Add fallback download link for non-deb/rpm linux
* Refactor os detection in scripts.js
* Remove rpm download text/links
* Refactor os detection for downloads
* Re-enable analytics
* Remove comma causing syntax error on chrome
* Remove console.log() statements
-- File Changes --
M _includes/homepage_content.html (188)
M _includes/os_selector_options.html (27)
M _layouts/default.html (122)
M downloads.html (13)
M js/markets.js (12)
M js/scripts.js (146)
-- Patch Links --
https://github.com/bisq-network/bisq-website/pull/102.patch
https://github.com/bisq-network/bisq-website/pull/102.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq-website/pull/102
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20181205/cb45c338/attachment.html>
More information about the bisq-github
mailing list