[bisq-network/bisq] Stream isolation for Tor (#2081)

[Florian Reimair]

freimair commented on this pull request.



> @@ -206,7 +206,7 @@ public static boolean isDaoActivated(Environment environment) {
             torRcFile, torRcOptions, externalTorControlPort, externalTorPassword, externalTorCookieFile,
             socks5ProxyHttpAddress, useAllProvidedNodes, numConnectionForBtc, genesisTxId, genesisBlockHeight, referralId, daoActivated;
 
-    protected final boolean externalTorUseSafeCookieAuthentication;
+    protected final boolean externalTorUseSafeCookieAuthentication, torStreamIsolation;

I have been thinking about that as well.
- However, in the past, we had some issues with `SecureRandom` on Linux taking an extraordinary amount of time to produce its first output (> 2 minutes) which could only be sped up by changing something in the OS.
- Furthermore, creating a random string and a new Socket every time takes time.
- Last but not least, I am not entirely sure if changing the socket everytime does effect network performance to the worse.

I added an "experimental!" to the option so we can life the `--streamIsolation` for a little while and see if we encounter any unforeseen issues. If, one day, we are convinced that everything is fine, we can use the feature by default.

Or should we do it the other way around and provide an off-switch to the feature?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/2081#discussion_r239739799
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20181207/1652e9c4/attachment-0001.html>