[bisq-network/bisq] Stream isolation for Tor (#2081)

Manfred Karrer notifications at github.com
Fri Dec 7 17:23:01 UTC 2018


ManfredKarrer commented on this pull request.



> @@ -206,7 +206,7 @@ public static boolean isDaoActivated(Environment environment) {
             torRcFile, torRcOptions, externalTorControlPort, externalTorPassword, externalTorCookieFile,
             socks5ProxyHttpAddress, useAllProvidedNodes, numConnectionForBtc, genesisTxId, genesisBlockHeight, referralId, daoActivated;
 
-    protected final boolean externalTorUseSafeCookieAuthentication;
+    protected final boolean externalTorUseSafeCookieAuthentication, torStreamIsolation;

Yes, good points. Is SecureRandom really needed at all here? I have not followed closely the context and motivation behind it but to keep it turned off by default is definitely better. 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/2081#discussion_r239884067
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20181207/49bc7025/attachment.html>


More information about the bisq-github mailing list