[bisq-network/bisq] Surgical fix to default command line parameters (#2090)

[Florian Reimair]

This request fixes #2084 similar to the fix introduced by @cbeams in #2063 (which addressed #2048).

This should get rid of all side-effects we encountered by providing the defaults in the JOptSimple parser already. Since #1961 did not remove any code concerning the "old" default handling this fix should be production ready.

However, as @cbeams mentioned in #1961, he has further changes regarding the command line argument parsing queued up. So `git revert` https://github.com/bisq-network/bisq/commit/e9ca340ccbf5517e95d5548011f567afedc5e47a (this commit)  and `git revert` https://github.com/bisq-network/bisq/pull/2063/commits/b122ff4104f14868dc50b0a38dd175e1edb7f8f3 should prepare Bisq for your queued changes again.


You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/2090

-- Commit Summary --

  * surgically fixes #2048, fixes #2084

-- File Changes --

    M core/src/main/java/bisq/core/app/BisqExecutable.java (120)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/2090.patch
https://github.com/bisq-network/bisq/pull/2090.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/2090
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20181207/c4b48f55/attachment.html>