[bisq-network/bisq] Handle rpc errors (#2098)

sqrrm notifications at github.com
Sun Dec 9 13:42:35 UTC 2018


sqrrm approved this pull request.

utACK

> -        if (throwable instanceof RpcException &&
-                throwable.getCause() != null &&
-                throwable.getCause() instanceof HttpLayerException &&
-                ((HttpLayerException) throwable.getCause()).getCode() == 1004004) {
-            errorMessage = "You have configured Bisq to run as DAO full node but there is not " +
-                    "localhost Bitcoin Core node detected. You need to have Bitcoin Core started and synced before " +
-                    "starting Bisq. Please restart Bisq with proper DAO full node setup or switch to lite node mode.";
+        throwable.printStackTrace();
+
+        if (throwable instanceof RpcException) {
+            Throwable cause = throwable.getCause();
+            if (cause != null) {
+                if (cause instanceof HttpLayerException) {
+                    if (((HttpLayerException) cause).getCode() == 1004004) {
+                        if (warnMessageHandler != null)
+                            warnMessageHandler.accept("You have configured Bisq to run as DAO full node but there is not " +

```suggestion
                            warnMessageHandler.accept("You have configured Bisq to run as DAO full node but there is no " +
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/2098#pullrequestreview-182978789
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20181209/cc10844e/attachment.html>


More information about the bisq-github mailing list