[bisq-network/bisq] [WIP] Fix Windows installer issues (#2103)

Devin Bileck notifications at github.com
Tue Dec 11 06:20:19 UTC 2018


devinbileck requested changes on this pull request.



>  function InitializeSetup(): Boolean;
 begin
 // Possible future improvements:
 //   if version less or same => just launch app
 //   if upgrade => check if same app is running and wait for it to exit
 //   Add pack200/unpack200 support?
+  DeleteOldAppDataDirectory;

Slight problem with putting it here. It removes the folder prior to starting the install. So if you cancel the installer, your Bisq app folder will be gone. I think it might need to be done in `PrepareToInstall()` method?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/2103#pullrequestreview-183392961
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20181210/5746d7f5/attachment-0001.html>


More information about the bisq-github mailing list