[bisq-network/bisq] Minor DAO ui fixes (#2109)

sqrrm notifications at github.com
Tue Dec 11 15:40:01 UTC 2018


sqrrm requested changes on this pull request.

NACK

Need to change all labels to upper case

> @@ -58,7 +58,7 @@ public MenuItem(Navigation navigation,
         this.viewClass = viewClass;
         this.baseNavPath = baseNavPath;
 
-        setLabelText(title);
+        setLabelText(title.toUpperCase());

This doesn't handle the 'Vote on proposals'/'Browse open proposals' text that changes depending on phase

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/2109#pullrequestreview-183743037
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20181211/dd1f320b/attachment.html>


More information about the bisq-github mailing list