[bisq-network/proposals] Bisq Network Monitor Revisited (#62)

[Florian Reimair]

> Pricesnodes

So what you are suggesting is to somehow merge the *Monitor Node* with the price node and thus, enable  Prometheus to fetch data directly from the price node? (i.e. exchange rates, fee estimation, number of live users, ...)
We can of course integrate the metric into the price node and only expose numbers (i.e. estimated number of active peers) to Prometheus.
Having said that, I second @ManfredKarrer s point about flexibility. I prefer to keep monitoring separated from other infrastructure components (such as the price nodes). That way, we can be sure to not expose any data that should not be exposed. Furthermore, by opening an additional public accessible API on such a critical part of the infrastructure does enlarge the attack surface considerably. Considering the floodfill characteristic of the P2P network, we might be able to estimate the network size without changing the price node. Furthermore, if a monitor node does query the price node as any other Bisq client does, we can keep that separated as well.

> Is monitoring service going to connect to the monitoring node over regular HTTP or WebSocket?

@blabno Prometheus uses plain HTTP to fetch a simple text document. The Metrics and measurements are encoded (i.e. human readable) into those documents by the monitor node. So yes, DoS is possible, however, as we know the Prometheus server (IP for example) we could do whitelisting. I added that feature to the *Settled* release as I am not sure if DoS against monitoring is that much of an issue.

> There is support for a GRPC API in place.

How would we use RPC for monitoring?

> how much we want to integrate the monitoring with other non P2P service

That is exactly the point. The Prometheus server does not care what data is to be collected. Why not reuse the Prometheus solution for the P2P monitoring as well. Low maintenance, easy to find, good overview, <abbr title="end of thinking capacity">etc</abbr>. Iff there is an issue with separation of concerns, we can always fire up a second Prometheus instance.




-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/proposals/issues/62#issuecomment-446913697
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20181213/4e983d46/attachment.html>