[bisq-network/bitcoinj] Basic support for version 2 transactions. (#16)

sqrrm notifications at github.com
Thu Dec 13 20:36:33 UTC 2018


sqrrm requested changes on this pull request.



> @@ -385,6 +385,14 @@ public boolean isOptInFullRBF() {
         return sequence < NO_SEQUENCE - 1;
     }
 
+    /**
+     * Returns whether this input, if it belongs to a version 2 (or higher) transaction, has
+     * <a href="https://github.com/bitcoin/bips/blob/master/bip-0068.mediawiki">relative lock-time</a> enabled.
+     */
+    public boolean hasRelativeLockTime() {
+        return (sequence & SEQUENCE_LOCKTIME_DISABLE_FLAG) == 0;

`SEQUENCE_LOCKTIME_DISABLE_FLAG` is not defined, was included in another commit with the same desciption in bitcoinj, 9e7cb1c951f630000b2d322e5bb2af827b597a10

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bitcoinj/pull/16#pullrequestreview-184855499
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20181213/7c697c54/attachment-0001.html>


More information about the bisq-github mailing list