[bisq-network/bisq] List Sunplatform (SUNP) (#2146)

[CaveSpectre11]

CaveSpectre11 requested changes on this pull request.

3 of the Invalid Addresses match the regex; as valid addresses:

```
$ egrep -v -e '.*valid [S][a-km-zA-HJ-NP-Z1-9]{24,33}$' addresses.txt
invalid sQEasE1ErGeSSqjruzL879UNPeV7sWbnAN
invalid SfCe8XrgG2

 $ egrep -e '.*valid [S][a-km-zA-HJ-NP-Z1-9]{24,33}$' addresses.txt
valid SQEasE1ErGeSSqjruzL879UNPeV7sWbnAN
valid SRK1eahAugt3k6BQjbR1EFYWTAGzg6uXPd
valid SfCe8XrgG2FTPLyuheJ2kMVTD4QehjPUPb
valid SkSJUTCgfJyGM6REhvt54JNQswnwsGHt5E
invalid SRK1eahBugt3k6BQjbR1EFYWTAGzg6uXpD
invalid SfCe8XrgG2FTPLyuheJ2kMVTD4QehjLULd
invalid SSSJUTCgfJyGM6REhvt54JNQswnwsGHt6e

```

> +    public SUNPTest() {
+        super(new SUNP());
+    }
+
+    @Test
+    public void testValidAddresses() {
+        assertValidAddress("SQEasE1ErGeSSqjruzL879UNPeV7sWbnAN");
+        assertValidAddress("SRK1eahAugt3k6BQjbR1EFYWTAGzg6uXPd");
+        assertValidAddress("SfCe8XrgG2FTPLyuheJ2kMVTD4QehjPUPb");
+        assertValidAddress("SkSJUTCgfJyGM6REhvt54JNQswnwsGHt5E");
+    }
+
+    @Test
+    public void testInvalidAddresses() {
+        assertInvalidAddress("sQEasE1ErGeSSqjruzL879UNPeV7sWbnAN");
+        assertInvalidAddress("SRK1eahBugt3k6BQjbR1EFYWTAGzg6uXpD");

The middle 3 addresses are valid according to your regex

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/2146#pullrequestreview-187578526
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20181221/34373b9e/attachment.html>