[bisq-network/bisq] List Webchain (WEB) (#2154)

[Bernard Labno]

blabno requested changes on this pull request.

NACK per comments
But you're almost there

> + *
+ * You should have received a copy of the GNU Affero General Public License
+ * along with Bisq. If not, see <http://www.gnu.org/licenses/>.
+ */
+
+package bisq.asset.coins;
+
+import bisq.asset.Coin;
+import bisq.asset.RegexAddressValidator;
+
+public class Webchain extends Coin {
+
+    public Webchain() {
+        super("Webchain", "WEB", new RegexAddressValidator("^0x[0-9a-fA-F]{40}$"));
+    }
+}

Add newline at the end of file

> +    @Test
+    public void testValidAddresses() {
+        assertValidAddress("0x8d1ba0497c3e3db17143604ab7f5e93a3cbac68b");
+        assertValidAddress("0x23c9c5ae8c854e9634a610af82924a5366a360a3");
+    }
+
+    @Test
+    public void testInvalidAddresses() {
+        assertInvalidAddress("");
+        assertInvalidAddress("8d1ba0497c3e3db17143604ab7f5e93a3cbac68b");
+        assertInvalidAddress("0x8d1ba0497c3e3db17143604ab7f5e93a3cbac68");
+        assertInvalidAddress("0x8d1ba0497c3e3db17143604ab7f5e93a3cbac68k");
+        assertInvalidAddress("098d1ba0497c3e3db17143604ab7f5e93a3cbac68b");
+        assertInvalidAddress("098d1ba0497c3e3db17143604ab7f5e93a3cbac68b");
+    }
+}

Add newline at the end of file

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/2154#pullrequestreview-187618238
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20181223/3a7daf35/attachment.html>