[bisq-network/bitcoinj] Failing tests (#19)

Oscar Guindzberg notifications at github.com
Mon Dec 24 22:08:57 UTC 2018


These tests fail on bisq's bitcoinj fork and need to be a) fixed or b) ignored and documented.

PeerTest
- Fails because of https://github.com/oscarguindzberg/bitcoinj/commit/f76a9daac3ba119057b5e663a8f185334c5fbeec
- writeTarget.writeBytes() is used to check the connection was in fact closed. Implementation before bisq change used to throw an exception if connection was already closed.

DeterministicKeyChainTest
- Ignored here https://github.com/oscarguindzberg/bitcoinj/commit/7712e3a35d2dae267b61f3c4d344aa59bbb03417 
- Fails becauses protobuf java was upgraded from 2.6.1 to 3.2.0 here https://github.com/oscarguindzberg/bitcoinj/commit/1c36ff94c0cb2b800964317565f562b0c397e74d


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bitcoinj/issues/19
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20181224/7d9fb0cc/attachment.html>


More information about the bisq-github mailing list