[bisq-network/bitcoinj] Clone transaction before adding to wallet (#18)

[sqrrm]

1. Yeah, I think you're right that the transcationConfidence fixes are no longer needed if the txs are never shared by two wallets.
2. Indeed, it's probably better to do the cloning in Wallet.receicePending() to guarantee that no tx is in multiple wallets. For the Wallet.receiveFromBlock() I notice it's already cloned before being added, see AbstractBlockChain:688 so I think the intention is that no tx should be shared between wallets but the internally shared for pending transactions case wasn't handled and not many people have been running with shared wallets like this.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bitcoinj/pull/18#issuecomment-449973919
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20181226/e83f6cbe/attachment.html>