[bisq-network/compensation] [WIP] For December 2018 (#198)

[Oscar Guindzberg]

## Summary

> _Specify the total amount of BSQ you are requesting, and the BSQ address that amount should be paid to:_

 - BSQ requested: TBD
 - BSQ address: TBD


## Contributions delivered

> _Provide links to contributions you have [delivered](https://github.com/bisq-network/proposals/issues/19), the amount of BSQ you are requesting for each, and any comments that will help stakeholders understand its value._


## Contributions in progress

> _Provide links to work you're involved with that is still [in progress](https://github.com/bisq-network/proposals/issues/19). **This section is optional,** and is for your own benefit in keeping track of what you're doing and keeping other contributors up to date with the same._


- Available online
    - TX considered non-standard due to unknown version number 2 
            - https://github.com/bisq-network/bisq/issues/1832 
            - https://github.com/bisq-network/bisq/pull/2127
            - https://github.com/bisq-network/bitcoinj/pull/16 
    - Feasibility for replacing Bitcoinj with Bitcoin Core SPV
        -  https://github.com/bisq-network/bisq/issues/1062#issuecomment-446755367 
    - Review BIP 44 Implementation 
        - https://github.com/bisq-network/bisq/issues/1853#issuecomment-447598673
    - When date of the seed is not specified use bisq 0.5 release date
        - https://github.com/bisq-network/bisq/commit/717f5fb9b2c55ccb69c26454b228d20079470eb0 
    - Bisq disconnected from local btc node
        - https://github.com/bisq-network/bisq/issues/1823#issuecomment-447605289 
    - jdk8 vs jdk 10
        - https://github.com/bisq-network/bitcoinj/issues/17 
        - https://github.com/oscarguindzberg/bitcoinj/commit/7bd0d3672ca772fa9ec1bd04eca742cfa57fcbef 
    - PR code cleanup
        - https://github.com/bisq-network/bisq/pull/2137
    - Remove Networks and AbstractBitcoinNetParams since they are not used
        - https://github.com/bisq-network/bisq/pull/2182
    - Fix getActiveKeyChain() typo 
        - https://github.com/bisq-network/bisq/pull/2151 
    - “Accepted offer failed to execute, went through anyway but never happened” bug review
        - https://github.com/bisq-network/bisq/issues/2112#issuecomment-449741123
    - bitcoinj rebase
        - Clean up commit history of bisq’s bitcoinj https://github.com/oscarguindzberg/bitcoinj/tree/bisq_0.14.4.1-rebase2
        - Rebase bisq’s bitcoinj from v0.14.7 https://github.com/oscarguindzberg/bitcoinj/tree/bisq_0.14.7 
        - run unit tests and make sure no more test fail compared to the ones that already fail on bisq’s bitcoinj 0.14.4.1 branch
        - Review upstream bitcoinj commits from v0.14.4 to v0.14.7
            - Remove bloq’s seed node
        - Make sure all changes done in the old bisq’s bitcoinj branch were ported to bisq_0.14.7 branch
        - Run manual tests on regtest (buy and sell btc on the bisq UI) to make sure everything still works with the new bisq_0.14.7 branch.
    - Fix failing tests on bisq's bitcoinj branch
        - https://github.com/bisq-network/bitcoinj/issues/19 
    - update harcoded seed nodes https://github.com/oscarguindzberg/bitcoinj/commit/524cbc63bc8878119fc0e75231397f65384adcc0 
    - Review “Clone transaction before adding to wallet” PR
        -  https://github.com/bisq-network/bitcoinj/pull/18
    - Prevent DoS attacks to bitcoinj. 
        - https://github.com/oscarguindzberg/bitcoinj/commit/f49faa4049aa88ae9af6bc33e16e346b3b6fd95b
        - https://github.com/oscarguindzberg/bitcoinj/commit/395393a11cf61cdc3a4f450857b05543dfb2c93b 
    - Create a couple of PR on bitcoinj upstream
        - https://github.com/bitcoinj/bitcoinj/pull/1679
        - https://github.com/bitcoinj/bitcoinj/pull/1678
        - https://github.com/bitcoinj/bitcoinj/pull/1669
        - https://github.com/bitcoinj/bitcoinj/pull/1668

    - Review the changes done by bisq to bitcoinj (don’t do a code audit of complex changes)
    - Evaluate using bitcoinj master
        - https://groups.google.com/forum/#!topic/bitcoinj/M05pt8Hwnw0


## Roles performed

> _Provide links to your [monthly report](https://github.com/bisq-network/proposals/issues/13) on any roles you are responsible for._


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/compensation/issues/198
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20181231/3edc4a8c/attachment-0001.html>