[bisq-network/bisq-website] update the blog (as discussed in latest issue) (#67)

Chris Beams notifications at github.com
Thu Jul 5 18:48:56 UTC 2018


cbeams requested changes on this pull request.

NACK. Please look at the source of other posts and understand Jekyll's "front matter" (the section at the top of the post in between the `---` delimiters.)

Look at the deploy preview of your post compared to other existing posts that have proper front matter:

Yours: https://deploy-preview-67--bisq-website.netlify.com/blog/bisq-v.0.7.1-released/

Another: https://deploy-preview-67--bisq-website.netlify.com/blog/the-bisq-dao-manifesto/

Notice how yours is not styled. Fixing the front matter will fix this. Follow convention with what you see. Read the documentation about front matter at https://jekyllrb.com to really understand what's going on: https://jekyllrb.com/docs/frontmatter/.

Additionally: the blog post as-is has no link to the actual release or downloads page. It is a bit too much of a copy and paste from the release notes in this way.



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq-website/pull/67#pullrequestreview-134774491
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20180705/019c2fa1/attachment.html>


More information about the bisq-github mailing list