[bisq-network/bisq-core] Sync up with changes from voting branch (#136)

Manfred Karrer notifications at github.com
Sun Jul 8 11:54:15 UTC 2018


There have been several changes in the voting branch (and api-integration) which I want to get into master to avoid that those branches run out of sync as well as to apply the improvements.
The main changes are:
- The handling of persisted data in the p2p library (https://github.com/bisq-network/bisq-p2p/issues/8)
- Improvements of the app setup to support API projects in headless mode as well as in mixed mode
- Use custom TxBroadcaster class for better error handling 

Beside that there are many smaller trivial improvements, fixes, refactoring and cleanups.

Changes in that project:
- Add DaoOptionKeys.DAO_ACTIVATED option key
- Add setupDevEnv, onApplicationStarted and startAppSetup to
BisqExecutable
- Rename BisqCoreApp to BisqHeadlessApp
- Rename BisqCoreAppMain to BisqHeadlessAppMain
- Add BisqSetupCompleteListener interface to BisqSetup
- Remove @Getters from BisqSetup handlers
- Change handling of setup complete handlers
- Remove Objects.requireNonNull and use null checks instead
- Add HeadlessApp class
- Add TxBroadcaster class with improved error handling
- Add TxBroadcastException and TxMalleabilityException
- Use TxBroadcaster.Callback instead of FutureCallback<Transaction>
- Remove Broadcaster
- Fix wrong dust limit value in comments
- Remove delay at updateBalance
- Add AccountAgeWitnessStorageService and TradeStatistics2StorageService
- Move BtcAddressValidator from desktop to core
- Move old setup classes to bisq.core.app.misc
You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq-core/pull/136

-- Commit Summary --

  * Sync up with changes vrom voting branch

-- File Changes --

    R src/main/java/bisq/core/CoreModule.java (7)
    M src/main/java/bisq/core/app/BisqEnvironment.java (16)
    M src/main/java/bisq/core/app/BisqExecutable.java (23)
    R src/main/java/bisq/core/app/BisqHeadlessApp.java (18)
    R src/main/java/bisq/core/app/BisqHeadlessAppMain.java (25)
    M src/main/java/bisq/core/app/BisqSetup.java (98)
    A src/main/java/bisq/core/app/HeadlessApp.java (31)
    M src/main/java/bisq/core/app/P2PNetworkSetup.java (4)
    M src/main/java/bisq/core/app/SetupUtils.java (3)
    M src/main/java/bisq/core/app/WalletAppSetup.java (12)
    R src/main/java/bisq/core/app/misc/AppSetup.java (5)
    R src/main/java/bisq/core/app/misc/AppSetupWithP2P.java (3)
    R src/main/java/bisq/core/app/misc/AppSetupWithP2PAndDAO.java (2)
    R src/main/java/bisq/core/app/misc/ExecutableForAppWithP2p.java (5)
    R src/main/java/bisq/core/app/misc/ModuleForAppWithP2p.java (4)
    M src/main/java/bisq/core/arbitration/DisputeList.java (3)
    M src/main/java/bisq/core/arbitration/DisputeManager.java (12)
    M src/main/java/bisq/core/arbitration/messages/DisputeMessage.java (1)
    M src/main/java/bisq/core/btc/BalanceModel.java (11)
    D src/main/java/bisq/core/btc/wallet/Broadcaster.java (104)
    M src/main/java/bisq/core/btc/wallet/BtcWalletService.java (20)
    M src/main/java/bisq/core/btc/wallet/InsufficientBsqException.java (5)
    M src/main/java/bisq/core/btc/wallet/TradeWalletService.java (15)
    A src/main/java/bisq/core/btc/wallet/TxBroadcastException.java (48)
    A src/main/java/bisq/core/btc/wallet/TxBroadcastTimeoutException.java (48)
    A src/main/java/bisq/core/btc/wallet/TxBroadcaster.java (127)
    A src/main/java/bisq/core/btc/wallet/TxMalleabilityException.java (50)
    M src/main/java/bisq/core/btc/wallet/WalletService.java (9)
    M src/main/java/bisq/core/btc/wallet/WalletsManager.java (22)
    M src/main/java/bisq/core/dao/DaoModule.java (3)
    M src/main/java/bisq/core/dao/DaoOptionKeys.java (1)
    M src/main/java/bisq/core/dao/DaoSetup.java (4)
    M src/main/java/bisq/core/dao/vote/blindvote/BlindVoteService.java (10)
    M src/main/java/bisq/core/dao/vote/proposal/ProposalService.java (11)
    M src/main/java/bisq/core/dao/vote/votereveal/VoteRevealService.java (12)
    M src/main/java/bisq/core/filter/FilterManager.java (3)
    M src/main/java/bisq/core/locale/CurrencyUtil.java (4)
    M src/main/java/bisq/core/offer/OfferUtil.java (29)
    M src/main/java/bisq/core/offer/placeoffer/tasks/CreateMakerFeeTx.java (28)
    M src/main/java/bisq/core/payment/AccountAgeWitness.java (1)
    M src/main/java/bisq/core/payment/AccountAgeWitnessService.java (12)
    A src/main/java/bisq/core/payment/AccountAgeWitnessStorageService.java (79)
    A src/main/java/bisq/core/payment/AccountAgeWitnessStore.java (83)
    M src/main/java/bisq/core/proto/persistable/CorePersistenceProtoResolver.java (14)
    M src/main/java/bisq/core/setup/CoreNetworkCapabilities.java (5)
    M src/main/java/bisq/core/trade/TradeModule.java (4)
    M src/main/java/bisq/core/trade/protocol/tasks/buyer_as_taker/BuyerAsTakerSignAndPublishDepositTx.java (14)
    M src/main/java/bisq/core/trade/protocol/tasks/seller/SellerBroadcastPayoutTx.java (14)
    M src/main/java/bisq/core/trade/protocol/tasks/seller_as_taker/SellerAsTakerSignAndPublishDepositTx.java (14)
    M src/main/java/bisq/core/trade/protocol/tasks/taker/CreateTakerFeeTx.java (24)
    M src/main/java/bisq/core/trade/statistics/TradeStatistics2.java (2)
    A src/main/java/bisq/core/trade/statistics/TradeStatistics2StorageService.java (80)
    A src/main/java/bisq/core/trade/statistics/TradeStatistics2Store.java (82)
    M src/main/java/bisq/core/trade/statistics/TradeStatisticsManager.java (9)
    A src/main/java/bisq/core/util/validation/BtcAddressValidator.java (52)
    M src/test/java/bisq/core/payment/AccountAgeWitnessServiceTest.java (2)

-- Patch Links --

https://github.com/bisq-network/bisq-core/pull/136.patch
https://github.com/bisq-network/bisq-core/pull/136.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq-core/pull/136
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20180708/d8b4e854/attachment-0001.html>


More information about the bisq-github mailing list