[bisq-network/bisq-desktop] Cannot build 0.7.1 (#1603)

[Chris Beams]

@ripcurlx wrote:

> Regarding bisq-common tags not been published. Do you mean the tags where not pushed?

No, they have all been published, but at some point during the release process, something triggered a `bisq-p2p:0.7.1` build that attempted to resolve `bisq-common:0.7.1` before bisq-common's `0.7.1` tag was actually published. This left `bisq-p2p:0.7.1` in a bad state on JitPack, making it impossible to resolve (by `bisq-desktop:0.7.1`) until the bad build was purged.

So the main thing is to ensure that builds are not attempted until all tags have been pushed. Just an order of operations thing in the release process.

But in any case, if we go with option two above, you'll catch any of these problems before they affect users like @suvayu, and you'll be able to fix them by purging any bad builds, re-triggering builds, etc, just like I did to fix this situation.

So I think the main thing is to insert a step in the build process where you check out bisq-desktop by tag and build it yourself to ensure all tagged JitPack deps work as expected. I would do this *before* putting together the final (composite-build driven) bisq-desktop binaries, just in case there's some issue you need to go back and correct.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq-desktop/issues/1603#issuecomment-404111199
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20180711/41dd8d99/attachment-0001.html>