[bisq-network/bisq-core] Implements Face to Face payment method (#138)

sqrrm notifications at github.com
Sun Jul 22 11:36:16 UTC 2018


sqrrm approved this pull request.

utACK

> +
+
+    ///////////////////////////////////////////////////////////////////////////////////////////
+    // API
+    ///////////////////////////////////////////////////////////////////////////////////////////
+
+    @Override
+    public String getPaymentDetails() {
+        return "Face to Face - Contact: " + contact + ", city: " + city + ", additional information: " + extraInfo;
+    }
+
+
+    @Override
+    public String getPaymentDetailsForTradePopup() {
+        // We don't show here more as the makers extra data are the relevant for the trade. City has to be anyway the
+        // same for maker and taker.

While it's true that the city has to be the same it might just be nice to have that confirmation that you're in the right city in case multiple f2f have been set up.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq-core/pull/138#pullrequestreview-139284255
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20180722/d57ace73/attachment.html>


More information about the bisq-github mailing list