[bisq-network/bisq-docs] 2 little possible typos correction (#55)

Chris Beams notifications at github.com
Tue Jun 5 17:50:38 UTC 2018


cbeams requested changes on this pull request.

NACK. Thanks, @HarryMacfinned for these suggested fixes. Please resubmit your changes in the form of one pull request per set of related changes. For example, if you have several typo fixes to, say, the phase-zero doc, please submit a single pull request with those changes. Do not submit it from your `master` branch. Submit the pull request from a branch named, for example, `phase-zero-fixes`. The base of that branch should be the current HEAD of the `master` branch of the `bisq-network/bisq-docs` repository. The easiest way to do this is to simply click the `Edit` button on the phase-zero doc in the GitHub web UI, make your changes and then GitHub will walk you through the process of submitting a pull request correctly. You can also read GitHub's excellent documentation on doing your first pull requests. 

With regard to the `getting-started-review` doc, you should submit any suggested fixes as a pull request against the doc in question, which is `getting-started.adoc` in this case. There is no need to add another file to the repository with your suggested fixes, and there is also no need to spell out your suggested fixes in comments here in GitHub. The best thing is to simply make edits to the file as you see fit, and then submit a pull request with those changes. Thanks.



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq-docs/pull/55#pullrequestreview-126082186
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20180605/08b05011/attachment.html>


More information about the bisq-github mailing list