[bisq-network/bisq-core] Fixes #117 (#118)

[Chris Beams]

cbeams approved this pull request.

utACK. I've added a couple review commits dealing with style nits, please check them out and the related new style guideline issues I've created for both.

And another nit: is there a reason, @ManfredKarrer that you created the issue at #117 and then subsequently created this pull request at #118? In general, if you know that you're going to fix an issue, just create a single pull request to deal with it. This makes it easier for everyone to deal with, especially reviewers, having one thing to look at instead of two, not having to jump between the issue and PR to read the description of the problem and to see the proposed fix, etc. I notice that this also happened with the back-to-back issue and pull request combo of #1566 and #1567.




-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq-core/pull/118#pullrequestreview-126301234
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20180606/14676dc6/attachment-0001.html>