[bisq-network/bisq-core] Fixes issue 1566 (#119)

[Chris Beams]

cbeams approved this pull request.

utACK. This looks fine as-is, but I've noticed that if my Bitcoin Core node is _not_ fully synced, that Bisq falls back to connecting to Bisq's federation of nodes. This is basically fine from a privacy perspective (assuming the user trusts our nodes), but it always surprises me when it happens, and it would be nice (I think) if Bisq gave me some kind of heads up that it's going to fall back to the federation, with the choice of letting it go ahead or quitting Bisq while waiting for my Bitcoin node to finish syncing. Not saying that we need to hold up this PR at all; just wanted to put this out there, since I'd been thinking about it lately anyway, and because it's related to this change.

See also my review comment at https://github.com/bisq-network/bisq-core/pull/118#pullrequestreview-126301234 regarding avoiding creating a separate issue and pull request pairs where a single pull request would suffice. Thanks.



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq-core/pull/119#pullrequestreview-126302873
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20180606/de83b9ff/attachment.html>