[bisq-network/bisq-p2p] Extend capability check for networkEnvelop (#10)

[sqrrm]

sqrrm approved this pull request.

utACK

> @@ -283,22 +283,26 @@ public boolean isCapabilitySupported(NetworkEnvelope networkEnvelop) {
             final PersistableNetworkPayload persistableNetworkPayload = ((AddPersistableNetworkPayloadMessage) networkEnvelop).getPersistableNetworkPayload();
             return !(persistableNetworkPayload instanceof CapabilityRequiringPayload) || isCapabilitySupported((CapabilityRequiringPayload) persistableNetworkPayload);
         } else {
-            return true;
+            return !(networkEnvelop instanceof CapabilityRequiringPayload) || isCapabilitySupported((CapabilityRequiringPayload) networkEnvelop);

This seems better than before, could there be any bad consequences from not sending some messages that are currently sent?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq-p2p/pull/10#pullrequestreview-131009135
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20180621/bd5bd7de/attachment-0001.html>