[bisq-network/bisq-p2p] Handle unknown PB data from encrypted messages (#11)

Manfred Karrer notifications at github.com
Fri Jun 22 09:27:57 UTC 2018


Depends on https://github.com/bisq-network/bisq-common/pull/25

- Use ProtobufferException for
CoreNetworkProtoResolver.fromProto(PB.NetworkEnvelope proto)
- Add raw PB data in case if an exception
- log error if the encrypted data contains unknown PB data

Note: We should refactor the resolvers with checked exceptions instead
of the ProtobufferRuntimeException, but for the moment we leave that to
not add too much complexity/risk for that release.
You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq-p2p/pull/11

-- Commit Summary --

  * Handle unknown PB data from encrypted messages

-- File Changes --

    M src/main/java/bisq/network/crypto/EncryptionService.java (10)
    M src/main/java/bisq/network/p2p/P2PService.java (9)
    M src/main/java/bisq/network/p2p/network/Connection.java (3)

-- Patch Links --

https://github.com/bisq-network/bisq-p2p/pull/11.patch
https://github.com/bisq-network/bisq-p2p/pull/11.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq-p2p/pull/11
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20180622/0c7a4634/attachment.html>


More information about the bisq-github mailing list