[bisq-network/bisq-core] Protobuffer exception handling (#122)
Manfred Karrer
notifications at github.com
Fri Jun 22 09:28:16 UTC 2018
https://github.com/bisq-network/bisq-common/pull/25 and https://github.com/bisq-network/bisq-p2p/pull/11
- Use ProtobufferException for
CoreNetworkProtoResolver.fromProto(PB.NetworkEnvelope proto)
- Add raw PB data in case if an exception
- log error if the encrypted data contains unknown PB data
Note: We should refactor the resolvers with checked exceptions instead
of the ProtobufferRuntimeException, but for the moment we leave that to
not add too much complexity/risk for that release.
You can view, comment on, or merge this pull request online at:
https://github.com/bisq-network/bisq-core/pull/122
-- Commit Summary --
* Rename ProtobufferException to ProtobufferRuntimeException
* Handle unknown PB data from encrypted messages
-- File Changes --
M src/main/java/bisq/core/app/SetupUtils.java (3)
M src/main/java/bisq/core/dao/vote/proposal/Proposal.java (4)
M src/main/java/bisq/core/dao/vote/proposal/ProposalPayload.java (4)
M src/main/java/bisq/core/dao/vote/result/VoteResult.java (4)
M src/main/java/bisq/core/locale/TradeCurrency.java (4)
M src/main/java/bisq/core/proto/CoreProtoResolver.java (14)
M src/main/java/bisq/core/proto/network/CoreNetworkProtoResolver.java (17)
M src/main/java/bisq/core/proto/persistable/CorePersistenceProtoResolver.java (10)
M src/main/java/bisq/core/trade/TradableList.java (4)
-- Patch Links --
https://github.com/bisq-network/bisq-core/pull/122.patch
https://github.com/bisq-network/bisq-core/pull/122.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq-core/pull/122
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20180622/a67e99b5/attachment.html>
More information about the bisq-github
mailing list