[bisq-network/bisq-desktop] Fix select currency issues after edit offer (#1578)
Manfred Karrer
notifications at github.com
Fri Jun 22 16:46:35 UTC 2018
ManfredKarrer requested changes on this pull request.
> }
public void initWithData(OpenOffer openOffer) {
this.openOffer = openOffer;
this.initialState = openOffer.getState();
this.paymentAccount = user.getPaymentAccount(openOffer.getOffer().getMakerPaymentAccountId());
+ // select the current offer payment account as default payment account
+ preferences.setSelectedPaymentAccountForCreateOffer(paymentAccount);
Is that needed in the base class or should that be only called in the createOffer sub class? If so, maybe better to overwrite initWithData there.
> @@ -131,9 +131,9 @@ protected void deactivate() {
///////////////////////////////////////////////////////////////////////////////////////////
public void initWithData(OpenOffer openOffer) {
+ model.initWithData(openOffer);
I would prefer if we don't have that call before the super call. Carries risky dependencies of order of calls (see my comment in other commit - maybe that solves the issue without changing here the order?)
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq-desktop/pull/1578#pullrequestreview-131266584
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20180622/e8c68c74/attachment.html>
More information about the bisq-github
mailing list