[bisq-network/bisq-assets] List PRiVCY (PRiV) (#34)

[Chris Beams]

> @cbeams what do you think about PRiVCY class name? I'd go with Privcy.

As general Java class naming style, `Privcy` would indeed be the way to go, but our convention here in bisq-assets has been to have the class name match precisely the spelling and capitalization of the asset as their promoters refer to it in their materials. Looking around the PRiVCY website, I see that they're quite consistent in that spelling, so let's keep it as-is in the PR. Basically, they've followed that convention, so it's all good.

However, the use of the lowercase 'i' in the ticker symbol `PRiV` is not conventional. I just double-checked, and all asset ticker symbols are upper case, so let's not diverge from that here. If you're happy with the code otherwise, then you can just push an additional commit renaming that ticker symbol. Or @privcycoin you can do the same of course.

Also @blabno, these conventions aren't written down anywhere explicitly other than this comment. Feel free to patch the `list-asset` doc with them if you like.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq-assets/pull/34#issuecomment-399516042
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20180622/1a860a02/attachment.html>