[bisq-network/bisq-core] Use BisqRiskAnalysis (#124)

Manfred Karrer notifications at github.com
Mon Jun 25 22:26:09 UTC 2018


Copied from DefaultRiskAnalysis as DefaultRiskAnalysis has mostly
private methods and constructor so we cannot override it.

Only change to DefaultRiskAnalysis is removal of the RBF check.
For Bisq's use cases RBF is not considered risky.

Requiring a confirmation for RBF payments from a users external
wallet to Bisq would hurt usability. The trade transaction requires
anyway a confirmation and we don't see a use case where a Bisq user
accepts unconfirmed payment from untrusted peers and would not wait
anyway for at least one confirmation.
You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq-core/pull/124

-- Commit Summary --

  * Use BisqRiskAnalysis

-- File Changes --

    A src/main/java/bisq/core/btc/wallet/BisqRiskAnalysis.java (273)
    M src/main/java/bisq/core/btc/wallet/WalletConfig.java (2)

-- Patch Links --

https://github.com/bisq-network/bisq-core/pull/124.patch
https://github.com/bisq-network/bisq-core/pull/124.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq-core/pull/124
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20180625/2274de13/attachment-0001.html>


More information about the bisq-github mailing list