[bisq-network/bisq-assets] List BitCloud (BTDX) (#29)

Chris Beams notifications at github.com
Tue Jun 26 09:16:27 UTC 2018


Hey @blabno, just a heads up that there's no need to have submitters squash commits if the only "extra commits" in question are review commits, e.g. the one here in which you applied Bisq's code style. It's actually useful to preserve such commits because it teaches others what the style deviation was.

What's _not_ useful is having N partial commits that put together the original pull request. We always those three changes (`Asset` implementation, test and registration) to be atomic, and thus squashed if necessary. Thanks.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq-assets/pull/29#issuecomment-400239759
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20180626/47c3f6d9/attachment-0001.html>


More information about the bisq-github mailing list