[bisq-network/bisq-core] Use BisqRiskAnalysis (#124)

Manfred Karrer notifications at github.com
Tue Jun 26 12:03:36 UTC 2018


ManfredKarrer commented on this pull request.



> +        analyzed = true;
+
+        Result result = analyzeIsFinal();
+        if (result != null && result != Result.OK)
+            return result;
+
+        return analyzeIsStandard();
+    }
+
+    @Nullable
+    private Result analyzeIsFinal() {
+        // Transactions we create ourselves are, by definition, not at risk of double spending against us.
+        if (tx.getConfidence().getSource() == TransactionConfidence.Source.SELF)
+            return Result.OK;
+
+        // For Bisq's use cases RBF is not considered risky

Agree. Will remove it. 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq-core/pull/124#discussion_r198116610
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20180626/25002248/attachment.html>


More information about the bisq-github mailing list