[bisq-network/bisq-p2p] Ack messages for all trade, offer- and dispute messages (#12)

[sqrrm]

sqrrm commented on this pull request.

utACK

> +    public String toString() {
+        return "AckMessage{" +
+                "\n     uid='" + uid + '\'' +
+                ",\n     senderNodeAddress=" + senderNodeAddress +
+                ",\n     sourceType=" + sourceType +
+                ",\n     sourceMsgClassName='" + sourceMsgClassName + '\'' +
+                ",\n     sourceUid='" + sourceUid + '\'' +
+                ",\n     sourceId='" + sourceId + '\'' +
+                ",\n     result=" + result +
+                ",\n     errorMessage='" + errorMessage + '\'' +
+                "\n} " + super.toString();
+    }
+
+    @Override
+    public long getTTL() {
+        return TimeUnit.DAYS.toMillis(10);

Not opposing, but what was the reasoning behind 10 days?

> @@ -322,6 +334,10 @@ public void removeMessageListener(MessageListener messageListener) {
                     "That might happen because of async behaviour of CopyOnWriteArraySet");
     }
 
+    public void addSupportedCapabilitiesListenerAsWeakReference(SupportedCapabilitiesListener listener) {

I find these overly long method names rather hard to read. It's preference, but I would prefer a shorter name and a comment on the details about the weak reference.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq-p2p/pull/12#pullrequestreview-131976419
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20180626/727d61cb/attachment-0001.html>