[bisq-network/bisq-p2p] Ack messages for all trade, offer- and dispute messages (#12)
Manfred Karrer
notifications at github.com
Tue Jun 26 12:16:45 UTC 2018
ManfredKarrer commented on this pull request.
> + public String toString() {
+ return "AckMessage{" +
+ "\n uid='" + uid + '\'' +
+ ",\n senderNodeAddress=" + senderNodeAddress +
+ ",\n sourceType=" + sourceType +
+ ",\n sourceMsgClassName='" + sourceMsgClassName + '\'' +
+ ",\n sourceUid='" + sourceUid + '\'' +
+ ",\n sourceId='" + sourceId + '\'' +
+ ",\n result=" + result +
+ ",\n errorMessage='" + errorMessage + '\'' +
+ "\n} " + super.toString();
+ }
+
+ @Override
+ public long getTTL() {
+ return TimeUnit.DAYS.toMillis(10);
The trade period can take about 1 week (sepa), so 10 days seems to be reasonable safe to not miss acks. Also the dispute can take sometimes longer if a peer need to wait for bank reply or the like. But agree hard to say whats the best value here....
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq-p2p/pull/12#discussion_r198120031
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20180626/398486c7/attachment.html>
More information about the bisq-github
mailing list