[bisq-network/bisq-assets] List Nano (NANO) (#32)

Chris Beams notifications at github.com
Tue Jun 26 16:30:05 UTC 2018


cbeams requested changes on this pull request.

Thanks for catching this, @blabno.

Sorry @n9Mtq4, this implementation is far too complicated. I'm not saying it's not correct, I'm saying that I'm not going to spend the time to figure it out for a coin I've never heard of. Please radically simplify this, being pragmatic where necessary, just use a regex to get a first approximation of correctness. Look through the codebase to find other uses of `RegexAddressValidator` and follow suit. Thanks.



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq-assets/pull/32#pullrequestreview-132103317
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20180626/851de75c/attachment-0001.html>


More information about the bisq-github mailing list