[bisq-network/bisq-assets] List Nano (NANO) (#32)

[Chris Beams]

It's really about being pragmatic here. This implementation as-is adds 2K+ lines of code to a codebase that currently defines hundreds of assets while remaining under 10K LoC total. The next longest class in the codebase is 10x shorter than the one in this implementation. It just doesn't work, in the name of full validation to grow the codebase by 20% for a single new asset.

A regex that captures the allowed prefixes and underscore, validates that everything is lowercase, and that the address is of the correct length will go a long way toward doing 'enough' validation. If we find that Nano is a huge hit on Bisq, and we start to see validation errors cropping up due to invalid checksums, we can revisit a more complete implementation then.

Note that we're going to ship v0.7.1 within the next couple days, so if you can touch this up in the meantime, we can still get it in by the release. Best regards.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq-assets/pull/32#issuecomment-400661158
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20180627/5954e22a/attachment.html>