[bisq-network/bisq-desktop] First wallet address gets reused (#1540)

Yuval Kogman notifications at github.com
Tue May 15 18:13:55 UTC 2018


the first address generated by the HD wallet gets reused repeatedly, other addresses were used, only once per address, but these are clustered around the first address (e.g. with oxt.me) , allowing transactions to be linked. this also discloses disclosing balances etc to counterparties who may have personally identifying information due to the nature of the transfers

as far as i can tell this is because `getOrCreateUnusedAddressEntry` is only used in `completePreparedGenericProposalTx`, whereas [change address generation](https://github.com/bisq-network/bisq-core/blob/0d830b74478b1b70365a7d02daa76ac11380e3b0/src/main/java/bisq/core/btc/wallet/BtcWalletService.java#L450) uses `getOrCreateAddressEntry`. i've not attempted to verify this claim, i only spent a few minutes browsing through the code.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq-desktop/issues/1540
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/github/attachments/20180515/1f84c4c9/attachment.html>


More information about the github mailing list