[bisq-network/proposals] Integrate HTTP API to bisq-network (#22)

[Manfred Karrer]

To integrate the Bisq HTTP-API work form @mrosseel and @blabno I suggest following proposal.

Adjust the BisqAppMain and BisqExecutable so that it can configure the correct startup for 3 different modes:
- Desktop only
- Desktop with HTTP-API enabled
- HTTP-API only in headless mode

The HTTP-API comes with it's own option keys which will be supported as well. The details how that will be done is not decided yet.

A big part of startup code is currently in MainViewModel and that has to be refactored to the core project.

The HTTP-API specific code would be added in a new project (bisq-http-api). There it might have initially still duplicated code which got extracted from ViewModel classes. That should be iteratively clean up by refactored code where code which is used now both from the UI and the API will be refactored to classes inside core, so we get rid of those code duplication.

An open question is we should already prepare also support for a grpc API model. I suggest to not do that now but once it is implemented.

One concern of @blabno is that we get too many different combinations of possible combinations how to run the app. I don't see that as an issue at least at the current state of basically possible 3 options. The grpc API would add another option but I doubt that all possible combinations makes sense. So from a first thoguht on it I assume there will be added 2 new optsions: grpc-only and grpc+Desktop. I don't see a use case to run both grpc + HTTP-API together. It might be well the case that the HTTP-API will wrap the grpc inside.

@cbeams, @mrosseel, @blabno: What is your opinion about that proposal? 
 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/proposals/issues/22
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/github/attachments/20180530/ffe3c63e/attachment.html>