[bisq-network/bisq-common] Fix startup bug (#22)

Chris Beams notifications at github.com
Tue May 1 15:39:41 UTC 2018


cbeams approved this pull request.

utACK.

Nit: `Database`, not `DataBase`. I added commit ad2d6b1 to fix this.

Nit: Not sure why merging master into `mk_master` was necessary here. Seems like this feature branch should have been created directly from the current `bisq-network:master`. Avoiding these merge commits (when possible) just makes everything cleaner.

Nit: Please don't end commit subject lines with a period (bisq-network/styles#9).



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq-common/pull/22#pullrequestreview-116603038
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20180501/0d110369/attachment-0002.html>


More information about the github mailing list