[bisq-network/bisq-core] Fix startup bug (#106)

Chris Beams notifications at github.com
Tue May 1 15:51:19 UTC 2018


cbeams approved this pull request.

utACK.

Thanks for referencing bisq-network/bisq-common#22 in the description. This is very helpful when reviewing these multi-repo PRs.

See nits and comments in my review of that PR.

And a nit that I meant to mention there, but forgot is length of lines in the body of commit d1e58c83. I've added a change to our shared IDEA configuration in bisq-network/bisq#5 that should make doing the right thing the default thing now.

@ManfredKarrer, please update your root `bisq` repository. Afterward, you should see these new settings kick in the next time you commit something from within IDEA.



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq-core/pull/106#pullrequestreview-116606781
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20180501/c32f327b/attachment-0002.html>


More information about the github mailing list