[bisq-network/bisq-desktop] Fix startup bug (#1526)
Chris Beams
notifications at github.com
Tue May 1 16:33:38 UTC 2018
cbeams approved this pull request.
utACK. See comments in related PRs linked from the description.
One style nit specific to this PR was addressed in my review commit 294da24 and I followed up a bit about this in Slack at https://bisq.slack.com/archives/C8MU98VSL/p1525181628000398.
@ManfredKarrer commented on it as well at https://github.com/bisq-network/bisq-core/pull/106#issuecomment-385675054.
I won't pursue this topic any further here in the context of this PR, but will create a bisq-network/style issue about it soon where we can discuss it more fully.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq-desktop/pull/1526#pullrequestreview-116619227
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20180501/f25904f4/attachment-0002.html>
More information about the github
mailing list