[bisq-network/bisq-docs] [WIP] Getting Started Guide (#43)

Chris Beams notifications at github.com
Wed May 2 13:19:08 UTC 2018


Looks great at a glance, @m52go, I'll provide more detailed comments later, but in the meantime, I've pushed a couple review commits, please see and study them above.

A few other nits:

 1. Pease read and follow our guidelines around commit comments at bisq-network/style#9.
 2. Configure your Git client for proper author metadata (first and last name)
 3. Set yourself up for GPG commit signing
 4. In the future, please submit PRs from a branch other than your `master` branch, e.g. in this case, `getting-started` would have been fine. I'll omit the reasons for this here, but can explain more fully later if you like.

Links to and further information about each of these things can be found in the [contributor checklist](https://docs.bisq.network/contributor-checklist.html).

Note that you can go back and touch up your existing commits with `git rebase --interactive`. You don't strictly need to do this, but if you're not already familiar with this hugely powerful Git tool, I'd recommend taking a little quality time to learn it. It allows you to rewrite history, change details about commits, etc. In this case, what you want to do is "reword" the commits above to conform to the style guidelines. Again, not a strict requirement at all, but mentioning it as this is a tool I use every day, and usually find that others are very happy to know about once they've learned it too.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq-docs/pull/43#issuecomment-385974667
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20180502/bd1b8251/attachment-0002.html>


More information about the github mailing list