[bisq-network/bisq-assets] List Nilu (NILU) (#2)

Chris Beams notifications at github.com
Mon May 7 14:14:29 UTC 2018


@blabno wrote:

> Code looks ok, but website is almost empty, knowledgebase is empty and code is just ETH fork with several commits so it looks highly suspicious.

Thanks for pointing this out, but as per https://docs.bisq.network/exchange/howto/list-asset.html#controversial-assets-may-be-put-to-a-vote, we intentionally take our opinion and judgements out of the asset listing process. If the code is correct, and the website / block explorer are functional, then the asset can get listed:

> Accepting a request to list a given asset does not imply endorsement of that asset by Bisq maintainers, contributors or co-founders. Bisq maintainers merge or reject asset listing pull requests based strictly on the formal requirements laid out in this document, not on any political, legal or ethical grounds.

@blabno, see my additional review commit at 27f0cd1. This code was too complicated, didn't follow our conventions very well (and is probably still doing too much). We could have just let this go, but the problem is that every asset that comes afterward may look at previously merged assets and get the idea that this sort of thing is OK. Over time, we end up with a bunch of broken windows. In the future, we should probably just more aggressively reject stuff, but in order to do that we need to more clearly articulate what is correct and what's not correct (from a style perspective, etc), and that just takes more time. Mostly, asset implementations have been pretty simple so far, and have followed our conventions pretty well, so I think we can hold off on doing any further work on this for now. Let's see how it goes.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq-assets/pull/2#issuecomment-387078293
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20180507/5a8ea065/attachment-0002.html>


More information about the github mailing list